feat: Trigger PostgreSQL Role reconciliation when password Secret changes#394
Open
Mirt0x wants to merge 1 commit into
Open
feat: Trigger PostgreSQL Role reconciliation when password Secret changes#394Mirt0x wants to merge 1 commit into
Mirt0x wants to merge 1 commit into
Conversation
Signed-off-by: Lucas Wittchen <lucas.wittchen@gmx.net>
Mirt0x
force-pushed
the
feat/add_reconcile_loop_on_pw_change
branch
from
8dcdb2e to
82dbcdf
Compare
Collaborator
|
Related: #348 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
namespacedSecretMapperandclusterSecretMapperthat list Roles and return reconcile requests for Roles whosePasswordSecretRefmatches the Secret.I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
go test ./pkg/controller/namespaced/postgresql/role ./pkg/controller/cluster/postgresql/roleboth packages passed locally
make reviewable](https://git.io/fj2m9)