Skip to content

Throttles Background Notary Proofs on Failure #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Step7750 merged 2 commits into from
Apr 15, 2026
+19 −7
Merged

Throttles Background Notary Proofs on Failure #388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eadd4b8
Throttles Background Notary Proofs on Failure
Step7750 Apr 15, 2026
be643fb
Merge branch 'master' into chore/prevent-repeat-bg-notary-failures
Step7750 Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions src/lib/alarms/rollback.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import {PingRollbackTrade} from '../bridge/handlers/ping_rollback_trade';
import {TradeStatus} from '../types/steam_constants';
import {isBackgroundNotaryRollbackEnabled, proveTradesInBackground} from './notary';
import {reportTradeError} from './error_report';
import {gStore} from '../storage/store';
import {StorageKey} from '../storage/keys';

interface RollbackTradeInfo {
steamTrade: TradeHistoryStatus;
Expand Down Expand Up @@ -52,13 +54,22 @@ export async function pingRollbackTrades(pendingTrades: SlimTrade[], tradeHistor
}

if (await isBackgroundNotaryRollbackEnabled()) {
try {
await proveTradesInBackground(rollbackTrades.map((r) => r.steamTrade));
console.log(`proved ${rollbackTrades.length} rollback trade(s) via notary`);
return;
} catch (e) {
console.error('notary proving failed, falling back to legacy ping', e);
reportTradeError(rollbackTrades[0].csfloatTrade.id, `background extension notary failed: ${e}`);
const lastFailure = await gStore.getWithStorage<number>(
chrome.storage.local,
StorageKey.LAST_NOTARY_BG_PROOF_FAILURE
);
if (lastFailure && lastFailure > Date.now() - 60 * 60 * 1000) {
console.log('skipping notary proof, last failure was less than 60 minutes ago');
} else {
try {
await proveTradesInBackground(rollbackTrades.map((r) => r.steamTrade));
console.log(`proved ${rollbackTrades.length} rollback trade(s) via notary`);
return;
} catch (e) {
console.error('notary proving failed, falling back to legacy ping', e);
await gStore.setWithStorage(chrome.storage.local, StorageKey.LAST_NOTARY_BG_PROOF_FAILURE, Date.now());
reportTradeError(rollbackTrades[0].csfloatTrade.id, `background extension notary failed: ${e}`);
}
}
}

Expand Down
1 change: 1 addition & 0 deletions src/lib/storage/keys.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ export enum StorageKey {
ACCESS_TOKEN = 'access_token',
LAST_TRADE_PING_ATTEMPT = 'last_trade_ping_attempt',
LAST_TRADE_BLOCKED_PING_ATTEMPT = 'last_trade_blocked_ping_attempt',
LAST_NOTARY_BG_PROOF_FAILURE = 'last_notary_bg_proof_failure',
PRICE_CACHE = 'price_cache', // Stores market hash name -> price mapping (~0.86MB)
SCHEMA_CACHE = 'schema_cache', // Stores the full CSFloat schema payload
THRESHOLD_CACHE = 'threshold_cache', // Stores FloatDB rank thresholds
Expand Down