chore(deps): update CodeMirror and Csound browser - #504
Open
hlolli wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the editor’s CodeMirror/Csound dependencies and adapts block-evaluation logic to the updated Csound language plugin parser (new syntax-tree node names), with new tests to validate context selection across ORC/SCO/CSD inputs.
Changes:
- Bump
@csound/browserand@hlolli/codemirror-lang-csound, and promote CodeMirror/Lezer packages to direct runtime dependencies. - Update block-evaluation context detection to use the language plugin’s new syntax node names and return types.
- Add Vitest coverage for selecting instruments, UDOs, top-level ORC statements, SCO lines, and CSD instruments; remove the old ambient module declaration.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/global.d.ts | Removes the ambient module declaration for the Csound CodeMirror language package. |
| src/components/editor/utils.ts | Updates block context discovery for new syntax-tree node names and tweaks evaluation selection/context handling. |
| src/components/editor/utils.test.ts | Adds tests for findSurroundingContext across ORC/SCO/CSD sources. |
| package.json | Updates dependency versions and declares CodeMirror/Lezer packages as runtime dependencies. |
| package-lock.json | Locks updated dependency tree for the CodeMirror/Csound upgrades. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@hlolli/codemirror-lang-csoundto1.0.0-alpha11.@csound/browserto7.0.0-beta32, the newest forward prerelease.Why
The new Csound language plugin uses one parser and changes its syntax-tree node names. Without the compatibility update, block evaluation inside instruments and UDOs would fall back to one line.
Checks
npm run typechecknpm run lintnpm run format:checknpm run test:ci— 12 tests passednpm run build