Make email optional on Leadership records - #210
Merged
Conversation
Allows uploading previous leadership records without an email address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous leadership records often don't have a known or current email address, but the leadership table's email column was required end-to-end (DB column, create schema, and admin form), which blocked uploading that historical data.
Changes:
emailnullable on theLeadershipmodel (wasnullable=False)LeadershipDTO/CreateLeadershipDTOto allowNonefor email (UpdateLeadershipDTOalready allowed it)requiredattribute and asterisk from the email field in the admin Leadership form, and sendnullinstead of an empty string when left blankLeadership/CreateLeadership/AdminLeadershipfrontend types to allownullemailmailto:link on the public leadership page so it only renders when an email is presentNote: existing deployed databases will need a manual
ALTER TABLE leadership ALTER COLUMN email DROP NOT NULLsince there's no migration tooling in this repo — the schema is created viametadata.create_all().Closes #207