Repository navigation
Fix issue with blank ee_images variable - #260
Merged
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The reviewed changes address blank image configuration and add validation before deployment.
Review effort: Lite
Findings: None
What changed in this PR
Fixes blank ee_images entries that prevented Ascender deployment.
Changes:
- Skips incomplete EE image entries.
- Removes empty
ee_imagesconfiguration. - Validates configured images before deployment.
| File | Description |
|---|---|
playbooks/roles/config_vars/tasks/kubernetes.yml |
Removes empty EE image lists. |
playbooks/roles/config_vars/tasks/ee_images.yml |
Validates and skips blank entries. |
playbooks/roles/ascender_install/templates/ascender-deployment/additional-spec.yml |
Cleans up image rendering. |
playbooks/assertions.yml |
Validates EE image configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
TheWitness
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The config_vars.sh script was adding an
ee_imagesvariable with a blank imagenameandimage.This would cause the operator to fail to deploy the web/task containers.
#229