Use events also when step definitions use "attach" and "log"

[brasmusson]

Description

Remove the ancient procedure call interface from formatters completely

Until now the data from "attach" and "log" calls from step definitions has been passed to the formatter using the ancient procedure call interface used in Cucumber-Ruby v1 and v2. From Cucumber-Ruby v3 all other data to formatters has been passed using events.

Introduce an event AttachCalled to pass the data from "attach" and "log" calls from step definitions to event listeners like formatters.

Type of change

Please delete options that are not relevant.

• Refactoring (improvements to code design or tooling that don't change behaviour)

Please add an entry to the relevant section of CHANGELOG.md as part of this pull request.

Checklist:

Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.

• Tests have been added for any changes to behaviour of the code
• New and existing tests are passing locally and on CI
• bundle exec rubocop reports no offenses
• RDoc comments have been updated
• CHANGELOG.md has been updated

[luke-hill]

This makes a lot of sense and removes some of the tech debt you mentioned. One QQ about some more stuff we can maybe cull

[StantonMatt]

I ran a focused check around the attach/log event path on 174d2a49 with Ruby 3.3.11.

bundle exec cucumber features/docs/writing_support_code/attachments.feature features/docs/defining_steps/printing_messages.feature features/docs/writing_support_code/hooks/hook_order.feature
bundle exec cucumber features/docs/formatters/json_formatter.feature features/docs/formatters/pretty_formatter.feature
bundle exec rspec spec/cucumber/formatter/json_spec.rb spec/cucumber/formatter/message_spec.rb spec/cucumber/formatter/pretty_spec.rb spec/cucumber/glue/proto_world_spec.rb spec/cucumber/glue/step_definition_spec.rb
git diff --check origin/main...HEAD

Results:

• docs attach/log/hook-order features: 7 scenarios, 55 steps, all passed
• JSON + pretty formatter features: 12 scenarios, 119 steps, all passed
• formatter/glue specs: 98 examples, 0 failures, 2 pending existing pending examples in ProtoWorld attachment specs
• git diff --check passed
• visible GitHub checks are also all green: 17/17, including RuboCop, CodeQL, and the full Ruby/platform test matrix

From that, I do not see a functional gap in the migration from visitor.attach/FanOut to configuration.notify(:attach_called, ...): the docs-level attach and log paths still reach message/json/pretty output, and the formatter/glue specs cover the MessageBuilder, JSON/pretty formatters, ProtoWorld, and step-definition bridge.

[luke-hill]

@brasmusson can you write up some technical level changelog for this please. This is a great change and this makes a LOT more sense to me, so thankyou a LOT for this! 🎉