Skip to content

fix(thermos): Pass rubric paths to review subagents - #177

Open
kmsquire wants to merge 1 commit into
cursor:mainfrom
kmsquire:fix/thermos-pass-rubric-paths
Open

fix(thermos): Pass rubric paths to review subagents#177
kmsquire wants to merge 1 commit into
cursor:mainfrom
kmsquire:fix/thermos-pass-rubric-paths

Conversation

@kmsquire

Copy link
Copy Markdown

Summary

  • Task subagents cannot execute /thermos or discover plugin skill files, so instructing them to "load the thermo-nuclear-* skill" wastes startup hunting for skills that never resolve.
  • Parents (thermos skill / any orchestrator) now resolve absolute SKILL.md paths (or inline the rubric body) and pass them in each Task prompt.
  • Subagent agent defs prefer parent-provided path / ### Rubric (inlined) and explicitly forbid filesystem skill searches and slash-skill invocation.
  • Bump Thermos to 1.0.1; document the parent contract in README and CHANGELOG.

Test plan

  • Invoke /thermos (or spawn both thermo review subagents) with a small branch diff
  • Confirm subagents Read the provided rubric path and do not search for thermos skills at startup
  • Confirm findings still reflect the security and code-quality rubrics
  • Confirm fallback still works when parent omits path and inlined rubric (degraded but usable review)

Made with Cursor

Task subagents cannot invoke slash skills, so telling them to "load the
thermo-nuclear-* skill" wastes startup on failed discovery. Have parents
resolve absolute SKILL.md paths (or inline the rubric) and instruct
subagents to Read that path instead.

Co-authored-by: Cursor <cursoragent@cursor.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before autofix could start.

Reviewed by Cursor Bugbot for commit 3f24066. Configure here.

1. this plugin's `skills/<skill-name>/SKILL.md` (when you know the install path)
2. `$HOME/.claude/skills/<skill-name>/SKILL.md`
3. newest match under
`$HOME/.cursor/plugins/cache/cursor-public/thermos/*/skills/<skill-name>/SKILL.md`

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incomplete rubric path search

Medium Severity · Bugbot Rules

The new rubric path search skips the standard Cursor skill install locations (workspace .cursor/skills/ and user ~/.cursor/skills/) and only checks $HOME/.claude/skills/ plus a narrow cursor-public/thermos cache glob. Skill detection that routes to other skills needs all three install roots, including general ~/.cursor/plugins/ (local and team marketplace too). Missed paths leave parents unable to pass rubrics, so subagents fall back to a degraded review.

Fix in Cursor Fix in Web

Triggered by learned rule: Skill detection must cover all installation paths

Reviewed by Cursor Bugbot for commit 3f24066. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant