Repository navigation
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two skills ship TypeScript scripts with their own test suites and typecheck configs:
orchestrate/skills/orchestrate/scripts(209 tests across 28 files,tsc --noEmit) andpstack/skills/poteto-mode/scripts(63 tests across 5 files,tsc --project watch-pr/tsconfig.json --noEmit --strict). Nothing runs them in CI:.github/workflows/validate-plugins.ymlonly validates manifests. This is piece 4 of the shape in #531. #492 just added aworktree-audittest under the pstack package that, today, nobody executes after merge.What
Adds
.github/workflows/script-packages.yml: a matrix over the two package directories,oven-sh/setup-bun@v2,bun install --frozen-lockfile, thenbun run typecheckandbun run testwithworking-directoryset to the package.fail-fast: falseso a failure in one package does not cancel the other. Triggers on PRs that touch either package or the workflow itself; the manifest validator keeps its own job.Checked
Both packages green locally with bun 1.4.3 on current
main:--frozen-lockfileworks against the committedbun.lockin both. Since the workflow file is in its ownpaths:list, the two jobs trigger on this PR as well; as a fork PR the run is sitting inaction_requireduntil a maintainer approves it, after which it is the first real execution.Refs #531.