Repository navigation
Show PR links directly in Slack notifications - #38
Conversation
|
Thanks for contributing to the Cyberwave Python SDK, @KhushiSharma22! A repository maintainer will follow up. When this PR is ready, we request a maintainer review and run an automated advisory review. CI and human review remain the source of truth. Please describe what changed and how you tested it. See the contribution guide or ask for help on Discord. Drafts are welcome. Merged human contributions receive a Discord thank-you. To opt out, check the PR template's Discord opt-out box or add |
|
Slack team notifications
|
Automated advisory review · ClaudeCommit: This review covers two patch excerpts: a Slack payload builder in a GitHub Actions script and its accompanying test. The only substantive change is adding an mrkdwn-typed section block containing the PR URL, and appending the URL to the fallback text field. One concrete defect is visible in the new mrkdwn block when the PR title contains Slack mrkdwn metacharacters injected via the URL path segment, but on closer inspection the URL is constructed from trusted repository metadata and a numeric PR number, so that specific vector is low-risk. However, there is a real structural bug in the test's section-index assumptions versus the actual block order produced by the updated code.
Coverage: 2 of 2 changed files; patch excerpts only. Generated REST code, lockfiles, notebooks, SVGs, missing patches and files beyond the 40-file / 60,000-character budget are excluded. GitHub may truncate individual patches. |
|
Thanks @KhushiSharma22 — your contribution has been merged! |
Slack PR notifications currently expose the GitHub URL only through the action button. Show the full clickable PR URL directly below the title/author details, and include it in the notification fallback text so it is also available in notification previews and accessible text.
Applies to draft, ready-for-review, and merged notifications. Keeps the existing action button; contributor-provided titles remain in plain-text blocks, while only the trusted GitHub URL uses Slack link formatting.
Validation: all 47 contributor automation tests pass, with the existing payload test checking visible and fallback links for all three notification stages.
git diff --checkpasses. Live Slack rendering remains to be checked after merge.