fix(worker): move Pages Function under apps/web for Git integration - #1023
Merged
Conversation
The Pages Git integration did not detect functions/ at the repo root — the project root is apps/web, so the function must live at apps/web/functions/ for the Cloudflare build to compile and serve it. Generated with Codebuff 🤖 Co-Authored-By: Codebuff <noreply@codebuff.com>
Deploying do-epub-studio with
|
| Latest commit: |
5fc12af
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2d4c3a0e.do-epub-studio.pages.dev |
| Branch Preview URL: | https://fix-pages-functions-location.do-epub-studio.pages.dev |
Contributor
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Bundle budget (gzipped, ADR-107 §3)Budgets: main JS 180 KB · main CSS 30 KB · any lazy chunk 80 KB Bundle budget (gzipped + brotli) — ADR-107 §3
Budgets: main JS 180 KB · main CSS 30 KB · lazy chunk 100 KB Baseline delta comparison
|
The Pages Git integration only detects functions/ under the project root (apps/web), not at the repo root — verified by deploying both. Update the GOAP plan, ADR, runbook, and learnings to the correct location. Generated with Codebuff 🤖 Co-Authored-By: Codebuff <noreply@codebuff.com>
github-actions
Bot
added
documentation
apps/web/functions/api/[[path]].ts is a runtime entry point bundled by Cloudflare at deploy time, never imported by app source, so knip flags it as an unused file. Add it to the apps/web ignore list. Generated with Codebuff 🤖 Co-Authored-By: Codebuff <noreply@codebuff.com>
|
✅ Health of changed files: 9.6 → 9.6 (+0.1) 📋 At a glance ✅ Health gate: passed 📌 Before you merge
🔎 More signals (2)🔥 Hotspot touched (1)
💀 Dead code (2 findings)
👀 Suggested reviewers @d-oit 📊 See the full report for this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Pages Git integration did not detect
functions/at the repo root (preview deployment had no_routes.json/_worker.js, and/api/healthreturned a 404). The Pages project root isapps/web, so the function must live atapps/web/functions/. Movesfunctions/api/[[path]].ts→apps/web/functions/api/[[path]].ts(import path updated).