Repository navigation
Conversation
AI-assisted implementation and verification using OpenAI Codex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
formatPrefix(".1", 0)returns a formatter that producesNaNfor every input, including zero and ordinary finite numbers. The exponent of a zero reference is undefined, so it propagates into the scale factor.Use exponent zero for a zero reference (including negative zero), which selects no SI prefix and retains the ordinary fixed-precision formatter. The regression covers zero, positive and negative inputs and a negative-zero reference. Existing nonzero-prefix behavior remains covered by the suite.
Validation: the new regression fails on unchanged main (
NaNinstead of0.0);npm test -- --runpasses all 169 tests,npm run lintandgit diff --checkpass on Node 22.23.1. Browser execution and the Node 12 minimum were not exercised.AI disclosure: OpenAI Codex assisted with investigation, implementation, regression tests, and this description.