chore: resolve form-data, ws, tmp CVEs via overrides - #2
Open
EightRice wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pins three transitive dependencies to patched versions via npm
overrides, addressing Dependabot alerts:4.0.0(via axios, hardhat-deploy) and2.5.1(via then-request). Patched:^4.0.6.8.17.1(via ethers),7.4.6(via @ethersproject/providers),7.5.10(via hardhat). Patched:^8.21.1.0.0.33(via solc, exact-pinned). Patched:^0.2.6.No direct dependencies were upgraded; all three are transitive deps pinned/ranged below the patched versions by their parents, so
overrideswas needed to force resolution.Test plan
npm install— resolves cleanly, lockfile confirmsform-data@4.0.6,ws@8.21.1,tmp@0.2.7(all single deduped instances now)npm audit— form-data, ws, tmp no longer appear in the vulnerability reportnpx hardhat compile— compiles all 62 Solidity files successfullynpx hardhat test— 0 passing / 9 failing, but failures are pre-existing and unrelated: all 9 are in the default Hardhat boilerplatetest/Lock.js, which references aLockcontract that doesn't exist in this repo'scontracts/directory (HH700: Artifact for contract "Lock" not found"). This file predates this change and was never adapted to the actual contract set.