chore: resolve form-data, ws CVEs via resolutions/overrides - #38
Open
EightRice wants to merge 1 commit into
Open
chore: resolve form-data, ws CVEs via resolutions/overrides#38EightRice wants to merge 1 commit into
EightRice wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pins two transitive dependencies to patched versions, addressing Dependabot alerts.
tmpwas checked but is not present anywhere in this repo's dependency tree, so no action was needed for it.4.0.0/4.0.2(via axios, superagent). Patched:^4.0.6.8.17.1/8.18.1(via ethers). Patched:^8.21.1.Both are transitive only (not direct deps), so
resolutions(yarn, which CI uses) andoverrides(npm) were added to package.json to force resolution. The repo has four tracked lockfiles (package-lock.json, pnpm-lock.yaml, bun.lockb, plus an untracked/gitignored yarn.lock that CI regenerates fresh on every run); all three tracked lockfiles were regenerated and now resolve to the patched versions. No direct dependency was upgraded.Test plan
npm install/pnpm install/bun install— all resolve cleanly; each lockfile now showsform-data@4.0.6andws@8.21.1npm audit— form-data and ws no longer appear in the vulnerability reportyarn install && yarn test(matches CI'stest.ymlexactly) — 58 passing / 4 failing, identical pass/fail counts and identical failure signatures (Mongoosebuffering timed out, inroutes/daos.test.js) as the pre-fix baseline onorigin/main. Confirmed by running the same suite before and after the dependency change — no regressions introduced by this PR.