Trying to get CI green - #269
Merged
Merged
Conversation
jvoisin
reviewed
Sep 2, 2026
| checkout je $version_je https://github.com/jemalloc/jemalloc | ||
| if grep -q 'std::__throw_bad_alloc' src/jemalloc_cpp.cpp; then | ||
| patch -p1 < ../../patches/jemalloc.patch | ||
| fi |
Collaborator
There was a problem hiding this comment.
I think something like sed -i s/std::__throw_bad_alloc();/throw std::bad_alloc();/ would be more portable
Collaborator
Author
There was a problem hiding this comment.
Good suggestion. Changed to that
Collaborator
Author
|
@jvoisin I'm planning to clear some of the backlog here. If you're happy with this, then I can work on the other PRs with a green baseline. |
Collaborator
|
LGTM :) |
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various fixes that seem sensible from copilot to get a Green CI.