Fix occasional error in debias#161
Open
ilariagabusi wants to merge 7 commits into
Open
Conversation
daducci
reviewed
May 13, 2026
| self.ICv = DICTIONARY['IC']['vox'] | ||
| self.ICo = DICTIONARY['IC']['dir'] | ||
| self.ICeval = DICTIONARY['IC']['eval'] | ||
| self.ICm = DICTIONARY['IC']['mask'] |
Owner
There was a problem hiding this comment.
What about DICTIONARY['IC']['debias_mask]?
daducci
reviewed
May 13, 2026
| unsigned int [::1] ICv | ||
| unsigned int [::1] ECv | ||
| unsigned int [::1] ISOv | ||
| unsigned int [::1] ICeval |
daducci
reviewed
May 13, 2026
|
|
||
|
|
||
| def build_operator( self ) : | ||
| def build_operator( self, mask_ic=None ) : |
Owner
There was a problem hiding this comment.
What about ic_debias_mask? In the future, we might also have ec_debias_mask etc
daducci
reviewed
May 13, 2026
| debias : boolean | ||
| If true, a debiasing step will be performed after the main fitting | ||
| procedure. Highly suggested when using a regularisation. (default : False) | ||
| debias_cond : float |
Owner
There was a problem hiding this comment.
This is de facto a threshold; what about debias_thr?
daducci
reviewed
May 13, 2026
| logger.info( 'Running debias' ) | ||
| logger.subinfo('') | ||
| logger.info( f'Running debias' ) | ||
| logger.subinfo( f'Creating mask for IC compartment with the condition: <={debias_cond:.2e}', indent_lvl=1, indent_char='*' ) |
Owner
There was a problem hiding this comment.
Perhaps, to be clearer, we can write Keeping columns whose corresponding x.....?
daducci
requested changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix error in saving results (RMSE and NRMSE maps) after debias, happening with some datasets when using BS or SZB models (Fixes #159).