Drop the polyfill for native workspace APIs - #30
Draft
grouville wants to merge 1 commit into
Draft
Conversation
grouville
force-pushed
the
polyfill-removal
branch
2 times, most recently
from
August 13, 2026 02:30
9f52831 to
748d3ce
Compare
The Go SDK used dagger/polyfill to discover managed modules, load module sources, stage generated files, and return only the changes made by one operation. The engine now provides those behaviors directly. Use currentModule.asSDK(workspace).modules for managed modules, thread the resulting Workspace through generation, and compare the final workspace with the workspace the SDK received. Remove the polyfill and bump the engine requirement together so returned paths are translated exactly once. Signed-off-by: Guillaume de Rouville <guillaume@dagger.io>
grouville
force-pushed
the
polyfill-removal
branch
from
August 14, 2026 07:52
38be4b1 to
90545b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Go SDK no longer needs
dagger/polyfill.Managed modules come from
currentModule.asSDK(workspace: ws).modules, using the registrations already present indagger.toml. Generation now keeps the workspace it received, applies each module's generated files to it, then returns only the difference:That explicit baseline matters during module initialization: the input already contains the new config and scaffold, so the SDK sees those files without returning them a second time. Paths are made cwd-relative once, by
Workspace.changes(from:).Init, clients, and config edits use the same pattern, and the polyfill dependency is removed.
Test
dagger check 'e-2-e:*'Requires dagger/dagger#13854 and dagger/dagger#13855.