Drop the polyfill for native workspace APIs - #16
Draft
grouville wants to merge 1 commit into
Draft
Conversation
grouville
force-pushed
the
polyfill-removal
branch
from
August 11, 2026 23:44
90265dd to
864d5d7
Compare
Signed-off-by: Guillaume de Rouville <guillaume@dagger.io>
grouville
force-pushed
the
polyfill-removal
branch
from
August 13, 2026 02:31
864d5d7 to
ae9c347
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TypeScript SDK no longer needs
dagger/polyfill.It reads managed modules from
currentModule.asSDK(workspace: ws).modules, then folds module and client generation directly onto the supplied workspace.ModuleSource.generate(workspace)handles dependency bindings internally and applies only each requested module's generated files, so dependency-owned or unrelated files do not leak into the result.The SDK calls
.changesonce at the end; the engine owns the generator baseline and cwd-relative paths.Test
dagger check e-2-e