Conversation
QMainWindow::restoreState() can corrupt internal separator bookkeeping (QTBUG-111538) when the saved windowState references a set of dock widgets that doesn't match the ones created this session, e.g. after an update added, removed, or renamed a dock. Qt logs "QDockAreaLayout::updateSeparatorWidgets: null separator widget" and the next relayout, triggered here by the first keypress, dereferences the null separator and crashes. Save the dock objectName() set alongside windowState, and skip restoreState() when it no longer matches the current set, falling back to the default layout instead of handing Qt a blob it can corrupt itself on. Confirmed the version-skew precondition exists in practice (a leftover HexViewerDock reference from before that dock was removed). Closes dail8859#1131
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QMainWindow::restoreState() can corrupt internal separator bookkeeping (QTBUG-111538) when the saved windowState references a set of dock widgets that doesn't match the ones created this session, e.g. after an update added, removed, or renamed a dock. Qt logs "QDockAreaLayout::updateSeparatorWidgets: null separator widget" and the next relayout, triggered here by the first keypress, dereferences the null separator and crashes.
Save the dock objectName() set alongside windowState, and skip restoreState() when it no longer matches the current set, falling back to the default layout instead of handing Qt a blob it can corrupt itself on.
Confirmed the version-skew precondition exists in practice (a leftover HexViewerDock reference from before that dock was removed).
Closes #1131