fix: resolve CI lint failures (MCP gosimple + Helm trailing spaces) - #5
Draft
daimoniac wants to merge 1 commit into
Draft
fix: resolve CI lint failures (MCP gosimple + Helm trailing spaces)#5daimoniac wants to merge 1 commit into
daimoniac wants to merge 1 commit into
Conversation
Convert identical MCP input structs with type conversions (gosimple S1016) and strip trailing spaces from charts/suppline/values.yaml for chart-testing. Co-authored-by: Stefan Knott <daimoniac@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI on
mainwas failing in two workflows after recent commits:golangci-lintgosimpleS1016 ininternal/mcp/tools.go: identical input→params structs should use type conversion instead of field-by-field literals.ct lintfailed on trailing spaces incharts/suppline/values.yaml.Changes
ListScansParams(in),ListVEXParams(in), etc. in MCP tool handlers.values.yaml.Validation