Skip to content

Fix: distribution field invisible — remove html field before complex field in Tab 3#14

Merged
daimpad merged 1 commit into
mainfrom
claude/evaluate-change-requests-FEyiS
May 15, 2026
Merged

Fix: distribution field invisible — remove html field before complex field in Tab 3#14
daimpad merged 1 commit into
mainfrom
claude/evaluate-change-requests-FEyiS

Conversation

@daimpad
Copy link
Copy Markdown
Owner

@daimpad daimpad commented May 15, 2026

Problem

After the previous fix (PR #13), the entire distribution field in Tab 3 was invisible — no "Add Entry" button, no form, just blank space after the intro text.

Root cause: Carbon Fields cannot render a complex field when a html-type field immediately precedes it in the same tab container. The odw_dist_intro html field (intro box explaining "Was ist eine Distribution?") was blocking CF from rendering the odw_distributions complex field.

This is a CF limitation: HTML fields and complex fields cannot coexist in the same tab-level array. Tab 4 works fine because its HTML fields are followed by simple fields (text, select, date), not complex fields.

Fix

  • Remove Field::make('html', 'odw_dist_intro') from Tab 3's field array
  • Fold the intro text into the complex field's set_help_text() so the explanation isn't lost
  • Remove the now-unused .odw-distribution-intro CSS rule from admin.css

Test plan

  • Tab 3 shows the distribution complex field with "Distribution hinzufügen" button
  • Clicking the button opens the distribution form (access_url, format, file size, license)
  • Multiple distributions can be added
  • All 90 PHPUnit tests pass

https://claude.ai/code/session_FEyiS


Generated by Claude Code

Carbon Fields cannot render a complex field when a html-type field
precedes it in the same tab container. Symptom: entire distribution
field invisible after intro text.

Remove the odw_dist_intro html field from the tab array and fold its
explanation text into the complex field's own help text. Also remove
the now-unused .odw-distribution-intro CSS rule.

https://claude.ai/code/session_FEyiS
@daimpad daimpad merged commit 0408c0c into main May 15, 2026
10 checks passed
@daimpad daimpad deleted the claude/evaluate-change-requests-FEyiS branch May 15, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants