Fix: Prevent collapse of Complex Fields when adding entries#16
Merged
Conversation
When clicking 'Add Entry' in the Datenbereitstellung (Data Preparation) tab, the entire Complex Field was unexpectedly collapsing. This was due to event bubbling causing the collapse toggle to be triggered. Added odw-complex-fix.js which uses stopPropagation() to prevent the 'Add Entry' button click from bubbling up to parent elements that might trigger collapse handlers. https://claude.ai/code/session_01JB1xUQM892bVZ4Yv3MZjvq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When clicking "Add Entry" in the Datenbereitstellung (Data Preparation) tab's Distribution Complex Field, the entire field was unexpectedly collapsing. This was caused by event bubbling triggering Carbon Fields' collapse handler.
Solution
Added
odw-complex-fix.jswhich usesstopPropagation()on the "Add Entry" button click to prevent the event from bubbling to parent elements that might trigger collapse handlers.Testing
Files Changed
assets/js/odw-complex-fix.js(new) — Prevents event bubbling on Complex Field action buttonsincludes/class-admin.php— Enqueues the new fix scriptGenerated by Claude Code