feat(tests): strengthen EIP-7981 gas and balance coverage - #61
Merged
danceratopz merged 8 commits intoSep 18, 2026
Merged
Conversation
spencer-tb
force-pushed
the
pr3537-review
branch
from
September 17, 2026 15:06
7ebee7b to
7ae4713
Compare
spencer-tb
force-pushed
the
pr3537-review
branch
from
September 17, 2026 15:08
7ae4713 to
7ebee7b
Compare
spencer-tb
marked this pull request as ready for review
September 17, 2026 15:10
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add coverage and fixture improvements from an independent review of ethereum#3537. This draft targets
7981-improve-testsfor inclusion in that PR.Several changes overlap with Louis’s review suggestions: fixture cleanup, making the floor tests exercise the floor, merging crossover cases, recipient and balance checklist coverage, and two-dimensional gas coverage.
The fixture-driven floor tests previously billed the intrinsic side. Resize their calldata and assert that the floor binds for types 1–3. Merge the crossover and dominance tests into five execution-gas offsets, and add exact/one-wei-short sender balance cases with zero and nonzero value.
Add a reservoir-backed storage-write test that pins block header gas independently of the transaction receipt. It covers the floor above the total bill, the floor between execution and total gas, and execution exceeding both the floor and state gas. The last case catches incorrectly using the floor alone for the execution dimension.
Fold the surplus constant into its fixture, remove the unused authorization-refund fixture, and simplify authorization parameter lookup. Keep
transaction_top_frame_gas_calculator: below the cap, type 4 authorization state gas spills into the sender's bill. Retained type 4 fixtures are unchanged; the two resized floor tests now exclude type 4.Related Issues or PRs
tests@v21.0.0(Glamsterdam Testnet) ethereum/execution-specs#3217Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.