Set uploaded asset metadata schemaKey to "Asset"

[candleindark]

Summary

Pin schemaKey to "Asset" on every metadata dict written to an asset endpoint. This is the lockstep client change for dandi/dandi-schema#419, which changes BareAsset.schemaKey from "Asset" to "BareAsset".

Whatever the metadata was gathered as (e.g. a BareAsset), what is created on the server is an Asset. The archive stores schemaKey verbatim and does not normalize it, so once BareAsset.schemaKey becomes "BareAsset", BareAsset-derived metadata would be stored with the wrong schemaKey. Setting it at the point of upload keeps this correct regardless of how the metadata was gathered.

It is a no-op against the current dandi-schema release (where BareAsset.schemaKey is still "Asset"), so it can merge and release ahead of the dandi-schema change.

What changed

schemaKey is set to "Asset" at every sink that writes to an asset create/update endpoint:

• LocalFileAsset.iter_upload and ZarrAsset.iter_upload (POST create / PUT replace), next to the existing metadata.setdefault("path", ...) step. Covers the normal CLI upload, the deprecated upload_raw_asset / iter_upload_raw_asset, and direct LocalAsset.upload() / iter_upload() API use.
• RemoteBlobAsset.set_raw_metadata and RemoteZarrAsset.set_raw_metadata (PUT update). The reextract service command reaches these with BareAsset-derived metadata (nwb2asset returns a BareAsset) without going through iter_upload.

RemoteDandisetVersion.set_raw_metadata is left untouched: it writes Dandiset metadata, not an asset.

Test adaptations for the BareAsset.schemaKey change

Two metadata tests hard-coded the top-level schemaKey of a BareAsset as "Asset", which becomes "BareAsset" under dandi/dandi-schema#419. Both now track the default of the schemaKey field in BareAsset rather than a literal, so they pass against the current dandischema and #419 alike:

• test_nwb2asset / test_nwb2asset_remote_asset: drop the redundant explicit schemaKey="Asset", which merely restated the field default.
• test_prepare_metadata: set the expected schemaKey to the default of the schemaKey field in BareAsset before the comparison (the four metadata2asset*.json files now store a placeholder for it), and promote the object to an Asset before the validate() call that checks it against the Asset class.

Test plan

• black --check clean on the changed files (verified out-of-band; the repo's pinned black currently crashes under Python 3.14, unrelated to this change)
• test_upload_download extended to assert the uploaded asset's stored schemaKey == "Asset" (needs the Docker-backed archive fixtures in CI)
• Confirm against the consolidated schema (BareAsset.schemaKey == "BareAsset") via DO NOT MERGE: check #1886 schemaKey handling against dandi-schema #419 #1888, which repoints the dandischema dependency at the Consolidate Asset/Dandiset models; gate publish validation on datePublished dandi-schema#419 branch

🤖 Generated with Claude Code

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.89%. Comparing base (3f2b6d1) to head (399da87).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1886      +/-   ##
==========================================
+ Coverage   76.88%   76.89%   +0.01%     
==========================================
  Files          88       88              
  Lines       12901    12909       +8     
==========================================
+ Hits         9919     9927       +8     
  Misses       2982     2982              

Flag	Coverage Δ
unittests	76.89% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[candleindark]

@yarikoptic Please take a look at this PR. We will need this merged and released in order to have the integration tests in dandi/dandi-schema#419 to become green.