fix(pulse): declare yaml dependency in Observability package.json#1396
Closed
badosanjos wants to merge 1 commit into
Closed
fix(pulse): declare yaml dependency in Observability package.json#1396badosanjos wants to merge 1 commit into
badosanjos wants to merge 1 commit into
Conversation
observability.ts imports 'yaml' but the package was never declared, so on a fresh install the Observability module fails to resolve and every dashboard page and /api/* route it serves returns 404 while the daemon itself runs. Fixes danielmiessler#1390
Owner
|
Thanks a lot for this, @badosanjos — really appreciate you flagging it and taking the time to write the fix. When I went back through the current source, this turns out to already be handled: yaml dependency already declared in current Pulse Observability package.json. The system has moved a fair bit since you opened this (the PAI → LifeOS rename and a few subsystem rewrites), so the gap you spotted has since been closed independently. Going to close this one out on that basis — but genuinely grateful for the contribution. 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1390.
observability.tsimportsyamlbut the package is not declared inPULSE/Observability/package.json(norPULSE/package.json). On a fresh v6.0.0 install the Observability module fails to resolve (Cannot find package 'yaml'), so the daemon runs but every dashboard page and/api/*route it serves returns 404.Fix: declare
yamlin dependencies (pinned^2.6.0; verified working with 2.9.x).Verified on Ubuntu 24.04 + bun 1.2.x: after
bun install, Pulse logsObservability module loadedand/+/api/telos/overviewreturn 200.