fix(pulse): use LIFEOS (all-caps) runtime dir in observability.ts#1397
Closed
badosanjos wants to merge 1 commit into
Closed
fix(pulse): use LIFEOS (all-caps) runtime dir in observability.ts#1397badosanjos wants to merge 1 commit into
badosanjos wants to merge 1 commit into
Conversation
DeployCore deploys the runtime to ~/.claude/LIFEOS (all-caps), but observability.ts hardcoded ~/.claude/LifeOS in three places. On case-sensitive filesystems (Linux) Pulse crash-loops with ENOENT on first start, and the crash loop mkdir's a stray real ~/.claude/LifeOS/ directory as a side effect. macOS is unaffected only because APFS is case-insensitive by default. Fixes danielmiessler#1391
Owner
|
Thanks a lot for this, @badosanjos — really appreciate you flagging it and taking the time to write the fix. When I went back through the current source, this turns out to already be handled: all-caps LIFEOS runtime dir is already the case in current source — thanks for catching the casing issue that has since been resolved. The system has moved a fair bit since you opened this (the PAI → LifeOS rename and a few subsystem rewrites), so the gap you spotted has since been closed independently. Going to close this one out on that basis — but genuinely grateful for the contribution. 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1391.
DeployCoredeploys the runtime to~/.claude/LIFEOS(all-caps), butobservability.tshardcodes~/.claude/LifeOSin three places (constLIFEOS_DIR, dashboard dir helper, and an env-fallback). On case-sensitive filesystems (Linux) Pulse crash-loops withENOENTon first start — and the crash loop mkdir's a stray real~/.claude/LifeOS/directory (capturespulse.pid) that then shadows any later symlink workaround. macOS is unaffected only because APFS defaults to case-insensitive.Fix: all three occurrences now use
LIFEOS, matching the deployer.Verified on Ubuntu 24.04: with paths aligned, Pulse boots clean under the shipped systemd user unit (
manage.sh install) and binds 127.0.0.1:31337.