Skip to content

Improve HttpClient usage for better efficiency #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yortw wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve HttpClient usage for better efficiency #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
111 changes: 77 additions & 34 deletions src/KloutSharp.Lib/Klout.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,28 +16,50 @@

namespace KloutSharp.Lib
{
public class Klout
public class Klout : IDisposable
{
private static string kloutUri = "http://api.klout.com/v2/";
private static string kloutIdentityUri = kloutUri + "identity.json/";
private const string kloutUri = "http://api.klout.com/v2/";
private static readonly string kloutIdentityUri = kloutUri + "identity.json/";
private string key;
public Klout(string key)
private HttpClient _HttpClient;

public Klout(string key) : this(key, CreateDefaultHttpClient())
{
this.key = key;
}
private void CheckKey()
public Klout(string key, HttpClient httpClient)
{
if (httpClient == null) throw new ArgumentNullException(nameof(httpClient));

this.key = key;
_HttpClient = httpClient;
}
private static HttpClient CreateDefaultHttpClient()
{
var handler = new System.Net.Http.HttpClientHandler();
if (handler.SupportsAutomaticDecompression)
handler.AutomaticDecompression = DecompressionMethods.GZip | DecompressionMethods.Deflate;

var retVal = new HttpClient(handler);
return retVal;
}
private void CheckKey()
{
if (string.IsNullOrEmpty(key))
throw new KloutException("Klout key not set!");
}
private string UriAddKey(string uri)
private void CheckIsDisposed()
{
if (_HttpClient == null) throw new ObjectDisposedException(nameof(Klout));
}
private string UriAddKey(string uri)
{
return string.Format("{0}{2}key={1}", uri, key, uri.Contains("?") ? "&" : "?");
}
public async Task<KloutIdentity> IdentityAsync(string id, KloutIdentityKind kind = KloutIdentityKind.TwitterScreenName)
{
CheckKey();
var parmeters = string.Empty;
CheckIsDisposed();
var parmeters = string.Empty;
switch (kind)
{
case KloutIdentityKind.TwitterId:
Expand Down Expand Up @@ -67,11 +89,10 @@ public async Task<KloutIdentity> IdentityAsync(string id, KloutIdentityKind kind
}
}
var uri = UriAddKey(string.Format(kloutIdentityUri + parmeters, id));
var client = new HttpClient();
var res = await client.GetAsync(uri);
var res = await _HttpClient.GetAsync(uri).ConfigureAwait(false);
if (res.IsSuccessStatusCode)
{
var content = await res.Content.ReadAsStringAsync();
var content = await res.Content.ReadAsStringAsync().ConfigureAwait(false);
var identity = JsonConvert.DeserializeObject<KloutIdentity>(content);
return identity;
}
Expand All @@ -82,33 +103,33 @@ public async Task<KloutIdentity> IdentityAsync(string id, KloutIdentityKind kind
}
public async Task<KloutIdentity> IdentityTwitterIdAsync(string id)
{
return await IdentityAsync(id, KloutIdentityKind.TwitterId);
return await IdentityAsync(id, KloutIdentityKind.TwitterId).ConfigureAwait(false);
}
public async Task<KloutIdentity> IdentityGoogle(string googleId)
{
return await IdentityAsync(googleId, KloutIdentityKind.Google);
return await IdentityAsync(googleId, KloutIdentityKind.Google).ConfigureAwait(false);
}
public async Task<KloutIdentity> IdentityInstagram(string instagramId)
{
return await IdentityAsync(instagramId, KloutIdentityKind.Instagram);
return await IdentityAsync(instagramId, KloutIdentityKind.Instagram).ConfigureAwait(false);
}
public async Task<KloutIdentity> IdentityTwitterScreenName(string twitter)
{
return await IdentityAsync(twitter, KloutIdentityKind.Instagram);
return await IdentityAsync(twitter, KloutIdentityKind.Instagram).ConfigureAwait(false);
}
public async Task<KloutIdentity> IdentityKlout(string kloutId)
{
return await IdentityAsync(kloutId, KloutIdentityKind.KloutId);
return await IdentityAsync(kloutId, KloutIdentityKind.KloutId).ConfigureAwait(false);
}
public async Task<KloutUser> UserAsync(string kloutId)
{
CheckKey();
var uri = UriAddKey(string.Format(kloutUri + "user.json/{0}", kloutId));
var client = new HttpClient();
var res = await client.GetAsync(uri);
CheckIsDisposed();
var uri = UriAddKey(string.Format(kloutUri + "user.json/{0}", kloutId));
var res = await _HttpClient.GetAsync(uri).ConfigureAwait(false);
if (res.IsSuccessStatusCode)
{
var content = await res.Content.ReadAsStringAsync();
var content = await res.Content.ReadAsStringAsync().ConfigureAwait(false);
var user = JsonConvert.DeserializeObject<KloutUser>(content);
return user;
}
Expand All @@ -120,12 +141,12 @@ public async Task<KloutUser> UserAsync(string kloutId)
public async Task<KloutScore> ScoreAsync(string kloutId)
{
CheckKey();
var uri = UriAddKey(string.Format(kloutUri + "user.json/{0}/score", kloutId));
var client = new HttpClient();
var res = await client.GetAsync(uri);
CheckIsDisposed();
var uri = UriAddKey(string.Format(kloutUri + "user.json/{0}/score", kloutId));
var res = await _HttpClient.GetAsync(uri).ConfigureAwait(false);
if (res.IsSuccessStatusCode)
{
var content = await res.Content.ReadAsStringAsync();
var content = await res.Content.ReadAsStringAsync().ConfigureAwait(false);
var score = JsonConvert.DeserializeObject<KloutScore>(content);
return score;
}
Expand All @@ -137,12 +158,12 @@ public async Task<KloutScore> ScoreAsync(string kloutId)
public async Task<List<KloutTopic>> TopicsAsync(string kloutId)
{
CheckKey();
var uri = UriAddKey(string.Format(kloutUri + "user.json/{0}/topics", kloutId));
var client = new HttpClient();
var res = await client.GetAsync(uri);
CheckIsDisposed();
var uri = UriAddKey(string.Format(kloutUri + "user.json/{0}/topics", kloutId));
var res = await _HttpClient.GetAsync(uri).ConfigureAwait(false);
if (res.IsSuccessStatusCode)
{
var content = await res.Content.ReadAsStringAsync();
var content = await res.Content.ReadAsStringAsync().ConfigureAwait(false);
var topics = JsonConvert.DeserializeObject<List<KloutTopic>>(content);
return topics;
}
Expand All @@ -154,12 +175,12 @@ public async Task<List<KloutTopic>> TopicsAsync(string kloutId)
public async Task<KloutInfluence> InfluenceAsync(string kloutId)
{
CheckKey();
var uri = UriAddKey(string.Format(kloutUri + "user.json/{0}/influence", kloutId));
var client = new HttpClient();
var res = await client.GetAsync(uri);
CheckIsDisposed();
var uri = UriAddKey(string.Format(kloutUri + "user.json/{0}/influence", kloutId));
var res = await _HttpClient.GetAsync(uri).ConfigureAwait(false);
if (res.IsSuccessStatusCode)
{
var content = await res.Content.ReadAsStringAsync();
var content = await res.Content.ReadAsStringAsync().ConfigureAwait(false);
var influence = JsonConvert.DeserializeObject<KloutInfluence>(content);
return influence;
}
Expand All @@ -168,5 +189,27 @@ public async Task<KloutInfluence> InfluenceAsync(string kloutId)
throw new KloutException(res.StatusCode);
}
}
}
}
public void Dispose()
{
try
{
Dispose(true);
}
finally
{
GC.SuppressFinalize(this);
}
}
protected virtual void Dispose(bool isDisposing)
{
if (isDisposing)
{
if (_HttpClient != null)
{
_HttpClient.Dispose();
_HttpClient = null;
}
}
}
}
}
4 changes: 2 additions & 2 deletions src/KloutSharp.Lib/Properties/AssemblyInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@
// You can specify all the values or you can default the Build and Revision Numbers
// by using the '*' as shown below:
// [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("1.0.3.0")]
[assembly: AssemblyFileVersion("1.0.3.0")]
[assembly: AssemblyVersion("1.0.3.1")]
[assembly: AssemblyFileVersion("1.0.3.1")]