DAOS-18304 ddb: add C unit tests for ddb_run_open#18214
Draft
knard38 wants to merge 1 commit into
Draft
Conversation
|
Ticket title is 'Add unit test to ddb go code' |
Add open_cmd_tests to ddb_commands_tests.c to cover the four main behaviors of ddb_run_open: - invalid path returns DER_INVAL - read-only (CoW) open sets dc_poh valid and dc_write_mode=false - write-mode open sets dc_poh valid and dc_write_mode=true - opening a pool that is already open returns DER_BUSY Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>
2ebb05b to
aaa9e2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR builds on top of #18124.
While working on that refactoring, it became apparent that
ddb_run_openlacked C-level unit test coverage.This patch addresses that gap.
It adds
open_cmd_teststoddb_commands_tests.c, covering the four main behaviors ofddb_run_open:DER_INVAL.write_mode=falseleavesdc_pohvalid anddc_write_modeset tofalsein the context.write_mode=trueleavesdc_pohvalid anddc_write_modeset totruein the context.DER_BUSY.Steps for the author:
After all prior steps are complete: