DAOS-16575 rebuild: set rgt DRS_COMPLETED for unretryable failure#18232
Open
liuxuezhao wants to merge 1 commit into
Open
DAOS-16575 rebuild: set rgt DRS_COMPLETED for unretryable failure#18232liuxuezhao wants to merge 1 commit into
liuxuezhao wants to merge 1 commit into
Conversation
If rebuild failed with unretryable failure, set it as DRS_COMPLETED to avoid following pool query always report rebuild busy such as - Rebuild failing (state=busy, status=-2001) after this patch, that kind of failed rebuild will report - Rebuild failed (state=done, status=-2001) This can fix test_rebuild_31/REBUILD31 problem. For test_rebuild_32/REBUILD32 add DAOS_POOL_TGT_UPDATE_SKIP_RF_CHECK to bypass DAOS_POOL_RF checking when changing pool map. Fixes: DAOS-16575 DAOS-16576 Test-tag: pr test_rebuild_31 test_rebuild_32 Signed-off-by: Xuezhao Liu <xuezhao.liu@hpe.com>
Contributor
daltonbohning
left a comment
daltonbohning
left a comment
There was a problem hiding this comment.
ftest changes LGTM
|
Ticket title is 'daos_test/rebuild.py:DaosCoreTestRebuild.test_rebuild_31 and test_rebuild_32 failures' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If rebuild failed with unretryable failure, set it as DRS_COMPLETED to avoid following pool query always report rebuild busy such as - Rebuild failing (state=busy, status=-2001)
after this patch, that kind of failed rebuild will report - Rebuild failed (state=done, status=-2001)
This can fix test_rebuild_31/REBUILD31 problem.
For test_rebuild_32/REBUILD32 add DAOS_POOL_TGT_UPDATE_SKIP_RF_CHECK to bypass DAOS_POOL_RF checking when changing pool map.
Fixes: DAOS-16575 DAOS-16576
Test-tag: pr test_rebuild_31 test_rebuild_32
Steps for the author:
After all prior steps are complete: