DAOS-18957 mgmt: improper assert#18236
Open
NiuYawei wants to merge 1 commit into
Open
Conversation
Fix the improper assert in ds_mgmt_pool_query_targets() which overlooked the case of querying down target. Signed-off-by: Niu Yawei <yawei.niu@hpe.com>
|
Ticket title is 'dmg pool query-targets failing for partially excluded ranks' |
Nasf-Fan
reviewed
May 13, 2026
| if (*mem_file_bytes == 0) { | ||
| *mem_file_bytes = mem_bytes; | ||
| } else { | ||
| D_ASSERT(mem_bytes == 0 || *mem_file_bytes == mem_bytes); |
Contributor
There was a problem hiding this comment.
The mem_bytes is from network, is it safe to assert that?
Contributor
Author
There was a problem hiding this comment.
I think it's fine. The PRC was successfully unpacked upon arrival, therefore, the invalid number points to a software bug rather than a transfer error.
wangshilong
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the improper assert in ds_mgmt_pool_query_targets() which overlooked the case of querying down target.
Steps for the author:
After all prior steps are complete: