DAOS-18949 container: improper assertion in cont_child_create_start#18238
Closed
Nasf-Fan wants to merge 1 commit into
Closed
DAOS-18949 container: improper assertion in cont_child_create_start#18238Nasf-Fan wants to merge 1 commit into
Nasf-Fan wants to merge 1 commit into
Conversation
The caller for cont_child_create_start() may not hold sp_recov_lock in advance, then the logic of cont_child_create_start() will try to take such lock by itself. Such ABT_rwlock_rdlock() maybe blocked by race or maybe not if there is no race. So it is not true to assume there will be CPU yield for such ABT rdlock. Then related assertion check "D_ASSERT(sched_seq1 != sched_seq2)" should be removed. Signed-off-by: Fan Yong <fan.yong@hpe.com>
|
Ticket title is 'erasurecode/multiple_rank_failure.py:EcodOnlineMultiRankFail.test_ec_multiple_rank_failure - timeout destroying container in tearDown' |
Contributor
Author
|
Not need it any longer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The caller for cont_child_create_start() may not hold sp_recov_lock in advance, then the logic of cont_child_create_start() will try to take such lock by itself. Such ABT_rwlock_rdlock() maybe blocked by race or maybe not if there is no race. So it is not true to assume there will be CPU yield for such ABT rdlock. Then related assertion check "D_ASSERT(sched_seq1 != sched_seq2)" should be removed.
Steps for the author:
After all prior steps are complete: