Skip to content

SRE-3827 test: assume fault injection is enabled by default (#18465)#18520

Open
janekmi wants to merge 1 commit into
release/2.8from
janekmi/SRE-3827-change-fault_status-default-2.8
Open

SRE-3827 test: assume fault injection is enabled by default (#18465)#18520
janekmi wants to merge 1 commit into
release/2.8from
janekmi/SRE-3827-change-fault_status-default-2.8

Conversation

@janekmi

@janekmi janekmi commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

If the fault_status executable is not available (e.g. on a light agent where DAOS is not installed) we cannot rule out there are tests to run. It does not change the behaviour when fault_status is available so no more tests will get run but less stages will get skipped without good reason when the test scope is restricted allowing to run a single fault injection test if necessary.

Fault injection test below picked arbitrarily.

Test-tag: test_daos_pipeline

Skip-unit-tests:true
Skip-NLT: true
Skip-unit-test-memcheck: true
Skip-func-vm: true
Skip-fault-injection-test: true
Skip-test-rpms: true

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

If the fault_status executable is not available (e.g. on a light agent
where DAOS is not installed) we cannot rule out there are tests to run.
It does not change the behaviour when fault_status is available so no
more tests will get run but less stages will get skipped without good
reason when the test scope is restricted allowing to run a single fault
injection test if necessary.

Fault injection test below picked arbitrarily.

Test-tag: test_daos_pipeline

Skip-unit-tests:true
Skip-NLT: true
Skip-unit-test-memcheck: true
Skip-func-vm: true
Skip-fault-injection-test: true
Skip-test-rpms: true

Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
@janekmi janekmi requested review from a team as code owners June 22, 2026 05:18
@github-actions

Copy link
Copy Markdown

Errors are Unable to load ticket data
https://daosio.atlassian.net/browse/SRE-3827

@janekmi janekmi added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Jun 22, 2026
@janekmi janekmi requested review from daltonbohning and grom72 June 22, 2026 05:19
@janekmi janekmi requested a review from a team June 30, 2026 07:19
@daltonbohning daltonbohning added waiting-for-merge-approval Waiting for merge approval forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. labels Jun 30, 2026
@daltonbohning daltonbohning added this to the release-2.8 milestone Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clean-cherry-pick Cherry-pick from another branch that did not require additional edits forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. waiting-for-merge-approval Waiting for merge approval

Development

Successfully merging this pull request may close these issues.

3 participants