Repository navigation
Kudos: tighten counting - #267
Merged
Merged
Conversation
- Count a kudos only from the site's own pages (the request's Origin) - One count per connection per entry per day - Clear the daily records after a day or two - Tests for each, with odd and hostile visitor addresses in payloads.mjs Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Nginuw5wmUjUSkmQB1J3pS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tightens how 👏 kudos are counted on the About card's XP entries.
Related Issue
None. Follow-up to #262, from a private review.
Changes Made
netlify/functions/kudos.mjs:Originis the site's own. That's this deploy's address,URL,DEPLOY_URLorDEPLOY_PRIME_URL. Browsers sendOriginon every tap, so nothing changes for visitors.visitorNet). No address is stored, as before.Tests:
tests/security/kudos.test.mjscovers each change.KUDOS_IPSinpayloads.mjsholds odd and hostile visitor addresses, which must never throw or grow the stored record.README: the kudos paragraph is updated.
How to Test
npm test: 296 pass.npm run generate.Additional Notes
Generated by Claude Code