Repository navigation
test: cover the single-pane tab strip and add a nightly idle CPU check - #448
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things that shipped without tests now have some.
The tab strip rule from #432 has two unit tests: a single pane hides its strip at one tab and shows it again at two or after a split, and a focused pane with a hidden strip hides its new-tab and split buttons instead of handing them to another pane. They live next to the other pane chrome tests and run on macOS 26 only, like their neighbours.
The nightly extended tests get an idle CPU job. It leaves one focused terminal sitting at a quiet prompt, measures the app's CPU over 30 seconds, and writes the number and focus state into the job summary. It's informational for now, with an 8% budget against a Debug build. Once a few nights show where runner numbers land, the budget gets tightened and the job made blocking. This replaces
test_cpu_usage.py, which never ran.Not covered: the display link parking from #430 has no hook visible outside the renderer, and the badge colours from #434 would need a render harness. The idle CPU job will show a #430 regression as a trend, not as a failure.