chore(ok_http): migrate to jni 1.0.0#1943
Open
EchoEllet wants to merge 6 commits into
Open
Conversation
EchoEllet
commented
Jun 30, 2026
Comment on lines
+156
to
159
| } on JThrowable catch (e) { | ||
| if (e.message.contains('java.io.IOException')) { | ||
| throw _JavaIOException(e); | ||
| } |
Author
There was a problem hiding this comment.
The previous workaround can be avoided now with the recent changes.
Source: https://pub.dev/packages/jni/changelog#100
Breaking Change: JniException has been deleted. Java exceptions are now thrown as JThrowable instead. JThrowable holds an actual Java exception, instead of just holding a string message. It's a JObject, so the usual .isA and .as methods work to cast the JThrowable to the underlying Java exception.
Screenshot
I have noticed that cronet_http could also use the same cleanup for consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes :
All the changes in the commit (f2130a6) were automated by
jnigen.Contribution guidelines:
dart format.Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.