Repository navigation
Conversation
Collaborator
|
This LGTM, but would you mind moving this over into the Dart SDK's |
Author
|
@bkonyi Done: dart-lang/sdk#64580 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flutter's
Mac web_tool_testshas been flaking for months because the extension backend can't start:Flutter passes hostname
anyby default, andHttpMultiServer.bind('any', port)binds[::]dual-stack. But the port comes fromfindUnusedPort(), which only checks[::1]withv6Only: true. That port can still be held over IPv4, so the dual-stack bind fails. Every retry uses the same probe, and in all of these failures all 5 attempts failed (~500ms before the error).Example CI failures:
This PR binds port 0 on the actual address, so the OS picks a port that's free for that exact bind. A requested port (e.g. the debug service's
44456) is still tried first, and the retry loop stays. #1451 moved away from port 0 because a single bind attempt failed without retrying (flutter/flutter#93256), so the retries still cover that case.I confirmed the mismatch on Linux: with
127.0.0.1:Por0.0.0.0:Pheld, a[::1]v6Only bind onPsucceeds and a[::]bind onPfails withEADDRINUSE. There's no deterministic regression test because the failure depends on which port the kernel hands out.Related to flutter/flutter#185452