Repository navigation
Dwds build runner tests - #2879
Merged
Merged
Conversation
github-actions
Bot
added
package:webdev
package:dwds
type-infra
biggs0125
force-pushed
the
dwds-build-runner-tests
branch
2 times, most recently
from
October 15, 2026 05:26
7d7e847 to
0f98d92
Compare
DWDS and dwds_test_common now live in the Dart SDK (pkg/dwds and pkg/dwds_test_common) and will be published from there. This commit only moves files so that the follow-up commit shows how each build_runner test changed. It moves the dwds files that have a counterpart in the new dwds_webdev_integration_test package (package config files, the test context, and the build daemon test wrappers) to their new locations, unchanged. The tree doesn't build at this commit; see the next commits.
This commit contains three changes: 1. Update all the tests to use the dwds_test_common shared test harness. 2. Migrate the dwds pubspec to the pubspec for the new unpublished package dwds_webdev_integration_test. 3. Add a README explaining this package/directory.
biggs0125
force-pushed
the
dwds-build-runner-tests
branch
from
October 15, 2026 15:11
2641903 to
ad46fd7
Compare
DWDS and dwds_test_common now live in the Dart SDK (pkg/dwds and pkg/dwds_test_common) and will be published from there. Their build daemon tests were moved to dwds_webdev_integration_test in the previous commits. - Delete the rest of dwds/ and dwds_test_common/. - webdev: depend on dwds_test_common only through the existing git override, and copy the `_webdev_smoke` fixture from the resolved package into a temp directory for the e2e and TLS tests. - webdev: since the `_webdev_smoke` fixture's SDK constraint is now owned by the Dart SDK, check that it allows every SDK webdev supports instead of requiring an exact match with webdev's constraint. - Point the README at the Dart SDK's copy of dwds.
- Run dwds_webdev_integration_test's tests on presubmit and in the weekly beta cron, using the same CI configuration dwds had (minus the dwds-only ensure_version_test), and its `daily` tests in the daily testing workflow. - Remove the dwds_test_common jobs, the dwds steps from the daily testing workflow, and the DWDS-only Dart Code Metrics workflow. - Give the daily testing workflow read-only `contents` permissions. - Update the labeler globs (also fixing the stale debug extension path). - Regenerate the mono_repo outputs (dart.yml and tool/ci.sh).
biggs0125
force-pushed
the
dwds-build-runner-tests
branch
from
October 15, 2026 23:00
ad46fd7 to
6d07b86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DWDS and dwds_test_common now live in the Dart SDK, which runs the shared integration test scenarios from
package:dwds_test_common/integrationwith the frontend server. This adds an unpublished package that runs the same scenarios against apps built by build_runner (via the build daemon), so the webdev copies of dwds and dwds_test_common can be deleted.dwds_webdev_integration_testdepends on dwds and dwds_test_common from the Dart SDK's main branch through git dependency overrides.BuildDaemonTestContextis the build_runner counterpart of the SDK'sFrontendServerTestContext.test/integration/build_daemon/contains wrappers for every build daemon configuration that webdev's dwds tests ran (AMD and DDC library bundle), following the structure of the SDK's frontend_server wrappers. The webdev-only ProxyServerAssetReader tests and the AMD ExpressionCompilerService test are also included.devchannel, plus the weekly beta cron), minus the dwds-onlyensure_version_test, and itsdailytests in the daily testing workflow.How to review
This PR is split into 4 commits to make the review easier. Each commit message describes the changes in that step, so reviewing commit by commit is the easiest way to follow it:
The intermediate commits don't build on their own; only the final state is expected to pass CI.