-
Notifications
You must be signed in to change notification settings - Fork 54
feat: enable DashPay iOS flow + key health tooling #3765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
2bf062c
ea4c16a
b83f935
68f98ad
7ae00b8
03f088f
03c5405
8f65db2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -405,8 +405,12 @@ impl Sdk { | |
|
|
||
| let documents = Document::fetch_many(self, query).await?; | ||
|
|
||
| // If no documents found, the name is available | ||
| Ok(documents.is_empty()) | ||
| // `Document::fetch_many` returns `BTreeMap<Identifier, Option<Document>>` | ||
| // — a non-existence proof comes back as a non-empty map whose values are | ||
| // all `None`. Checking `documents.is_empty()` would treat a proven | ||
| // non-existence as "taken". The name is available iff no entry in the | ||
| // map carries an actual document. | ||
| Ok(documents.values().all(|d| d.is_none())) | ||
|
Comment on lines
406
to
+413
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Suggestion: The semantic change from source: ['claude']
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Acknowledged, not addressed in this commit. An automated test for |
||
| } | ||
|
|
||
| /// Resolve a DPNS name to an identity ID | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.