Skip to content

test(dpp): require shielded-client in shield-from-asset-lock signing tests #3827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuantumExplorer merged 2 commits into from
Jun 9, 2026
Merged

test(dpp): require shielded-client in shield-from-asset-lock signing tests #3827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b54703
test(dpp): require shielded-client in shield-from-asset-lock signing …
QuantumExplorer Jun 9, 2026
a395cba
fix(platform-wallet): build outgoing-notes load errors via Persistenc…
QuantumExplorer Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .../src/state_transition/state_transitions/shielded/shield_from_asset_lock_transition/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ mod proved;
#[cfg(all(
test,
feature = "state-transition-signing",
feature = "core_key_wallet"
feature = "core_key_wallet",
feature = "shielded-client"
))]
mod signing_tests;
mod state_transition_estimated_fee_validation;
Expand Down
7 changes: 6 additions & 1 deletion ..._transition/state_transitions/shielded/shield_from_asset_lock_transition/signing_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,15 @@
//! in `state_transition::mod` pins `sign_with_core_signer` against
//! `sign_by_private_key` — we don't re-derive that contract here.

// `crate::shielded::builder` (the high-level bundle builder these tests drive) only
// exists under `shielded-client`, so this module must require it too — otherwise the
// `--all-targets` feature-unified lib-test target (which enables `state-transition-signing`
// + `core_key_wallet` without `shielded-client`) fails to resolve the builder import.
#![cfg(all(
test,
feature = "state-transition-signing",
feature = "core_key_wallet"
feature = "core_key_wallet",
feature = "shielded-client"
))]

use crate::identity::state_transition::asset_lock_proof::chain::ChainAssetLockProof;
Expand Down
13 changes: 6 additions & 7 deletions packages/rs-platform-wallet-ffi/src/persistence.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1430,10 +1430,10 @@ impl PlatformWalletPersistence for FFIPersister {
.on_load_shielded_outgoing_notes_free_fn
.is_some()
{
return Err("on_load_shielded_outgoing_notes_fn and \
on_load_shielded_outgoing_notes_free_fn must be provided together"
.to_string()
.into());
return Err(PersistenceError::backend(
"on_load_shielded_outgoing_notes_fn and \
on_load_shielded_outgoing_notes_free_fn must be provided together",
));
}

// 1) notes
Expand Down Expand Up @@ -1508,11 +1508,10 @@ impl PlatformWalletPersistence for FFIPersister {
let rc =
unsafe { load_outgoing(self.callbacks.context, &mut out_ptr, &mut out_count) };
if rc != 0 {
return Err(format!(
return Err(PersistenceError::backend(format!(
"on_load_shielded_outgoing_notes_fn returned error code {}",
rc
)
.into());
)));
}
struct OutgoingGuard {
context: *mut c_void,
Expand Down
Loading