Skip to content

test(sdk): match ban info entry by exact URI#3956

Closed
thepastaclaw wants to merge 1 commit into
dashpay:fix/rs-dapi-client-rate-limit-rotatefrom
thepastaclaw:fix-pr3951-ban-info-uri
Closed

test(sdk): match ban info entry by exact URI#3956
thepastaclaw wants to merge 1 commit into
dashpay:fix/rs-dapi-client-rate-limit-rotatefrom
thepastaclaw:fix-pr3951-ban-info-uri

Conversation

@thepastaclaw

Copy link
Copy Markdown
Collaborator

Fixes the Copilot review note on #3951 by matching the ban-info entry using the exact address URI instead of a substring search for the port.

Validation:

  • CARGO_INCREMENTAL=0 git commit ... pre-commit hook passed cargo fmt --all -- --check and workspace cargo check
  • CARGO_INCREMENTAL=0 cargo test -p rs-dapi-client test_invariant_genuine_failure_still_bans_with_unchanged_ladder

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c02958b6-115b-42e7-8736-e2e2b2321cb8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thepastaclaw

thepastaclaw commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator Author

✅ Review complete (commit d3e0d9f)

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Test-only change that tightens a substring URI match to an exact equality check in a banlist test. Both agents agree there are no in-scope defects and the change aligns with how ban_info() stores URIs via addr.to_string().

No in-scope findings.

Note: GitHub does not allow the PR author account to approve its own PR, so this clean automated review is posted as a comment review.

@thepastaclaw

Copy link
Copy Markdown
Collaborator Author

Closing this as obsolete: the target branch moved on and the brittle ban-info URI lookup was resolved directly on #3951. This stacked PR now conflicts with the updated branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant