feat: make API parameters explicit for better IDE support - #177
Merged
Conversation
lzsweb
reviewed
Aug 18, 2026
| format: str, # pylint: disable=redefined-builtin | ||
| sample_rate: int, | ||
| workspace: str = None, | ||
| # Recognition parameters |
- Remove dead code _get_protocol_params and its unused import; UA-merge logic now exists in a single place (_build_api_request) - Extract _merge_recognition_params helper to deduplicate repeated recognition-parameter merge blocks in Recognition (3 sites) and TranslationRecognizerRealtime/Chat (5 sites) - Use Optional[...] annotations for explicit parameters introduced by the refactor (factory, Application.call, recognition, translation_recognizer, tokenization) Behavior unchanged; all 460 unit tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this PR does and why]
Related Issue: Fixes #[issue_number] or Relates to #[issue_number]
Security Considerations: [Check if API keys or sensitive credentials are exposed in code/logs]
Type of Change
Component(s) Affected
Checklist
Testing
[How to test these changes]
Additional Notes
[Optional: any other context]