Skip to content

Extend the fix from ab72092 #9328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacobtomlinson merged 1 commit into from
Jul 12, 2026
+10 −10
Merged

Extend the fix from ab72092 #9328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions distributed/dashboard/tests/test_scheduler_bokeh.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1132,16 +1132,16 @@ async def test_proxy_to_workers(s, a, b):
assert response_direct.code == 200
assert b"System" in response_direct.body

dashboard_port = s.http_server.port
http_client = AsyncHTTPClient()
unsafe_host = "<><><>" # Some unsafe characters that should be escaped
proxy_url = f"http://localhost:{dashboard_port}/proxy/1234/{unsafe_host}/status"
response = await http_client.fetch(proxy_url, raise_error=False)
if proxy_exists:
dashboard_port = s.http_server.port
http_client = AsyncHTTPClient()
unsafe_host = "<><><>" # Some unsafe characters that should be escaped
proxy_url = f"http://localhost:{dashboard_port}/proxy/1234/{unsafe_host}/status"
response = await http_client.fetch(proxy_url, raise_error=False)
assert response.code == 400
assert unsafe_host not in response.body.decode(), (
"Unsafe characters should be escaped"
)
assert unsafe_host not in response.body.decode(), (
"Unsafe characters should be escaped"
)


@gen_cluster(
Expand Down
4 changes: 2 additions & 2 deletions distributed/http/proxy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,9 @@ def initialize(self, dask_server=None, extra=None):
self.extra = extra or {}

def get(self, port, host, proxied_path):
worker_url = f"{host}:{port}/{proxied_path}"
worker_url = html.escape(f"{host}:{port}/{proxied_path}")
msg = f"""
<p> Try navigating to <a href=http://{worker_url}>{worker_url}</a> for your worker dashboard </p>
<p> Try navigating to <a href="http://{worker_url}">{worker_url}</a> for your worker dashboard </p>

<p>
Dask tried to proxy you to that page through your
Expand Down
Loading