Repository navigation
direct: fail bind when the deployment state cannot be read - #6331
Merged
Merged
Conversation
Collaborator
Integration test reportCommit: 6a20618
Top 3 slowest tests (at least 2 minutes):
|
andrewnester
approved these changes
Aug 20, 2026
denik
force-pushed
the
denik/bind-state-open-error
branch
from
August 24, 2026 09:35
70ec539 to
134ca03
Compare
Bind treated any failure to open the state as "resource not bound": it skipped the already-managed check and then bound over state whose ownership was never verified, overwriting it. A crashed deploy that left a WAL behind was enough to trigger this, and bind still reported success. A state file that does not exist opens as an empty one, so absence of a binding is already covered; return the error instead. Co-authored-by: Isaac
Existence only shows a file is there; diff.py shows bind left the WAL byte for byte as it was, so a truncated or rewritten WAL fails the test. Co-authored-by: Isaac
Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/bind-state-open-error
branch
from
October 14, 2026 11:27
7748fcb to
4846972
Compare
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
deco-sdk-tagging Bot
added a commit
that referenced
this pull request
Oct 14, 2026
## Release v1.21.0 ### CLI * Support pipeline IDs in `pipelines history`. ([#6995](#6995)) * Show a hint for previewing more rows in `pipelines show`. ([#6995](#6995)) * `databricks environments setup-local` now uses the environment in `UV_PROJECT_ENVIRONMENT` when it is set, as `uv sync` does. ([#7026](#7026)) * `databricks environments setup-local` now supports uv workspace members: it uses the shared `.venv` at the workspace root and writes the dependency constraints to the root `pyproject.toml`. ([#7018](#7018)) ### AI Runtime * Limit `databricks air run` submission preflight validation to one five-second attempt before continuing when the service is unavailable. ([#6994](#6994)) ### Bundles * Bundle file uploads now use the multipart `POST /api/2.0/workspace/import` endpoint instead of the deprecated `POST /api/2.0/workspace-files/import-file`, raising the per-workspace upload rate limit and improving deploy throughput under concurrency. ([#6149](#6149)) * Diagnostic paths now quote map keys that are not identifiers, e.g. `resources.jobs['${var.env}_job']`. ([#6980](#6980)) * No longer include `CLAUDE.md` in the bundle templates, now that Claude supports `AGENTS.md`. ([#7000](#7000)) * Fix `bundle deployment bind` silently binding over a deployment state it could not read, which could take over a resource that was already managed by the bundle. ([#6331](#6331)) * `databricks bundle deploy`, `databricks bundle sync` and `databricks sync` now retry file, library, state and metadata uploads that fail with a transient server error (5xx or 408), instead of failing. ([#7014](#7014)) * `databricks bundle deploy`, `databricks bundle sync` and `databricks sync` now retry the workspace path check (`workspace/get-status`) when it fails with a transient server error (5xx or 408) or an HTTP/2 `REFUSED_STREAM`, instead of failing. ([#7044](#7044)) * Fixed `experimental.immutable_folder` failing validation for targets with `mode: development` ("file_path must start with '~/' or contain the current username"). ([#7027](#7027)) * Fixed `experimental.immutable_folder` failing with `experimental.deployment_history` ("workspace_info.file_path must be an absolute workspace path") and failing `bundle validate` when top-level `permissions` are set. ([#7001](#7001)) * Translate relative `.env` file paths in a job's `environment_variables[].spec.files` to their deployed workspace locations. ([#6985](#6985)) * Resolve job `project_environment` paths relative to the YAML file that defines them. ([#6983](#6983)) ### Dependency Updates * Bump Go toolchain to 1.26.9. ([#6996](#6996)) * Update Go SDK to 0.188.0. ([#7038](#7038))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bundle deployment bindtreated any failure to open the state as "resource not bound": it skipped the already-managed check, bound over state whose ownership was never verified, and overwrote it — while reporting success. A crashed deploy that left a WAL behind was enough to trigger this.A state file that does not exist opens as an empty one, so the absence of a binding is already covered by a successful open. Return the error instead.
Tests
New acceptance test that deploys a job, leaves a WAL from a different lineage next to the state, and binds: it used to print "Successfully bound" and replace the state file.