acc: build CLI with FIPS toolchain so go test matches release - #6369
Open
ilyakuz-db wants to merge 2 commits into
Open
acc: build CLI with FIPS toolchain so go test matches release#6369ilyakuz-db wants to merge 2 commits into
go test matches release#6369ilyakuz-db wants to merge 2 commits into
Conversation
Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: a09a086
Top 7 slowest tests (at least 2 minutes):
|
…S140 Co-authored-by: Isaac <no-reply@databricks.com>
denik
approved these changes
Aug 25, 2026
| // binary as `task` and the release build; otherwise acceptance/fips (which | ||
| // asserts the FIPS build settings) fails outside `task`. | ||
| repoRoot := ".." | ||
| RunCommand(t, args, repoRoot, []string{"GOOS=" + osName, "GOARCH=" + arch, "GOFIPS140=" + readGOFIPS140(t, repoRoot)}) |
Contributor
There was a problem hiding this comment.
nit: readGOFIPS140 is called multiple times, because BuildCLI is called multiple times; could be moved to global var so it's only done once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Build the CLI binary with the FIPS toolchain in
BuildCLI, reading the pinnedGOFIPS140version fromTaskfile.yml. Previously the FIPS build settings were only set via the Taskfile's globalenv:, so a plaingo test ./acceptanceproduced a non-FIPS binary andacceptance/fipsfailed.Why
The
acceptance/fipstest is a sanity check that we ship a FIPS build. It only passed when run throughtask, which exportsGOFIPS140. Setting it in the roottest.tomldoesn't help because it's a build-time toolchain env, not a runtime one — it has to be applied where the test builds the binary. Reading it fromTaskfile.ymlkeeps a single source of truth.Tests
go test ./acceptance -run TestAccept/fipsnow passes both with and withoutGOFIPS140set in the environment.