Improve AIR log retrieval reliability - #6414
Open
ben-hansen-db wants to merge 1 commit into
Open
Conversation
Collaborator
Integration test reportCommit: ee3a5be
Top 3 slowest tests (at least 2 minutes):
|
ben-hansen-db
force-pushed
the
ben-hansen/air-snapshot-workspace-parity
branch
from
August 27, 2026 23:37
29c379d to
6ba3037
Compare
ben-hansen-db
force-pushed
the
ben-hansen/air-log-retrieval-reliability
branch
from
August 27, 2026 23:37
cf199c8 to
12eb9b3
Compare
ben-hansen-db
changed the base branch from
ben-hansen/air-snapshot-workspace-parity
to
main
August 27, 2026 23:37
ben-hansen-db
force-pushed
the
ben-hansen/air-log-retrieval-reliability
branch
from
August 27, 2026 23:42
12eb9b3 to
ee3a5be
Compare
ben-hansen-db
marked this pull request as ready for review
August 27, 2026 23:50
Contributor
Approval status: pending
|
ben-hansen-db
commented
Aug 27, 2026
| @@ -0,0 +1 @@ | |||
| Improved AIR log fallback, retry-attempt selection, and Unity Catalog volume artifact handling. | |||
Contributor
Author
There was a problem hiding this comment.
I see a world where we don't have the MLflow artifact fallback but I'm not sure when bricklens will be stable so we should include it
vinchenzo-db
approved these changes
Aug 28, 2026
Comment on lines
+365
to
+366
| if volumeRoot, ok := volumeArtifactRoot(root); ok { | ||
| fc, err := filer.NewWorkspaceFilesClient(w, volumeRoot) |
Contributor
There was a problem hiding this comment.
pls verify that NewWorkspaceFilesClient is what should be used for UC Volumes. I will stamp to unblock but make sure to verify.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Why
Make AIR log streaming and downloads reliable across artifact backends, retries, and active runs.
Tests
go test ./experimental/air/cmdThis PR was written with Codex.