Add bump-serverless-env-version skill - #6419
Open
rugpanov wants to merge 8 commits into
Open
Conversation
Automates the serverless environment version bump across bundle templates: the serverless_environment_version macro plus the hardcoded literals in default-scala and lakeflow-integrations, the coupled Python / DB Connect pins in default/, golden regeneration across both template trees, and the mandatory verify pass. Delegates policy to .agents/rules/template-versions.md. Follow-up to #6378. Co-authored-by: Isaac <no-reply@databricks.com>
- Scope: defaultServerlessVersion (libs/localenv/envkey.go) is a separate "latest LTS" Go pin, not the SSH test fixture; tell the bumper to check and bump it in sync rather than "leave it alone". - Step 2: make the grep the source of truth; the file list is orientation only. Co-authored-by: Isaac <no-reply@databricks.com>
- Remove GOTOOLCHAIN=local from the golden commands: env-specific, diverges from bump-sdk/bump-tf, and can break contributors on older local Go. - Step 6: defer PR body to pr-checklist + the PR template (Changes/Why/Tests in order + authorship disclosure) instead of a competing template that dropped ## Why; broaden pre-PR checks to fmt/checks/lint/test. - Step 2: only version-bearing grep hits get edited (macro names / template references carry no literal). - Step 5: spell out the release-notes URL slug convention (five/six). Co-authored-by: Isaac <no-reply@databricks.com>
- Scope: when bumping defaultServerlessVersion, also refresh the version shown in its help/example/error strings (cmd/environments/sync.go, libs/localenv/constraints.go), not just regenerate tests. - Step 5: don't extrapolate the changelog line from v5 — adapt the benefit to the target version's actual release notes and link its real URL. Co-authored-by: Isaac <no-reply@databricks.com>
The "-update lets both EnvMatrix variants overwrite each other's output" explanation is stale: -update now auto-enables -subset (acceptance_test.go), regenerating each output file from one covering variant. Correct the rationale (the non-update pass matters because it runs *every* variant against the goldens) and stop framing a load-induced timeout as an automatic flake. Co-authored-by: Isaac <no-reply@databricks.com>
- Intro: only the golden output under acceptance/ is regenerated (acceptance/ also holds hand-maintained inputs), not "everything under acceptance/". - Step 3: use the full path libs/template/templates/default/library/versions.tmpl. Co-authored-by: Isaac <no-reply@databricks.com>
Only the conservative_db_connect_version_spec and python_version_spec blocks carry version-specific reasoning; name them instead of implying every macro does. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: d6add1c
Top 3 slowest tests (at least 2 minutes):
|
rugpanov
marked this pull request as ready for review
August 28, 2026 09:34
Contributor
Waiting for approvalCould not determine reviewers from git history. Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
Narrow the trigger, target golden regeneration, separate the localenv fallback, and cross-check prior template bumps while keeping the workflow concise. Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add the
bump-serverless-env-versionskill under.agents/skills/for upgrading the default serverless environment version shipped by bundle templates.The skill captures the non-obvious parts of the workflow: coupled Python and DB Connect compatibility, macro and hardcoded version sources, the separate
defaultServerlessVersionproduct fallback, targeted golden regeneration across both template acceptance trees, and cross-verification against prior bumps #3897 and #6378.Why
The version 5 bump in #6378 was performed manually. This makes future bumps repeatable while keeping policy in
.agents/rules/template-versions.mdand the procedural skill concise.Tests
git diff --checkpasses../task checkscould not run because the environment has Go 1.26.4, the branch requires Go 1.26.7, and the sandbox could not reach the Go toolchain download.This PR was written with Claude Code and Codex.