Repository navigation
Validate DMS resource types in the test server - #7039
Open
shreyas-goenka wants to merge 6 commits into
Open
shreyas-goenka wants to merge 6 commits into
shreyas-goenka wants to merge 6 commits into
Conversation
Collaborator
Integration test reportCommit: 67fff13
Top 50 slowest tests (at least 2 minutes):
|
andrewnester
approved these changes
Oct 14, 2026
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas-goenka/dms-resource-type-validation
branch
from
October 14, 2026 11:58
a4f8329 to
17acacb
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Validate staged operation resource types in the DMS test server against the 34 prefixes supported by Universe's
bundle/metadata-service. Unsupported prefixes return HTTP 400 before recording a version. Add a NOTE to update the corresponding Universe enum and prefix mapping when adding a type here.Local acceptance runs assert the test server's DMS rejection before exercising unsupported resource lifecycles with file-backed state. Live-workspace runs exercise those lifecycles with file-backed state directly. The immutable-folder DMS test verifies rejection without a recorded version and retains its deployment metadata path checks.
Why
The test server accepted any resource key containing a dot, so unsupported types such as
mcp_servicespassed local validation and failed against the real service. Acceptance tests must also respect the service's resource-type support.Tests
go test ./libs/testserver ./libs/dms ./bundle/direct/dstate ./bundle/phasesGOTOOLCHAIN=go1.26.8 go tool -modfile=tools/go.mod golangci-lint run ./libs/testserver/...ResourceTypes.java.