Skip to content

Use short workspace IDs in the acceptance test server - #7040

Merged
shreyas-goenka merged 5 commits into
mainfrom
shreyas-goenka_data/testserver-short-workspace-ids
Oct 14, 2026
Merged

shreyas-goenka merged 5 commits into
mainfrom
shreyas-goenka_data/testserver-short-workspace-ids

Conversation

@shreyas-goenka

Copy link
Copy Markdown
Contributor

Use short, unique TreeIDs for workspace objects and DMS deployments. Normalize deployment paths in the shared acceptance config so the Universe runner no longer needs to inject its own replacement; version numbers and counts remain visible.

Validated: full DMS suite (22 directories), workspace/file acceptance tests, unit and race tests, lint, formatting, and repository checks.

@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: 1965f68

Run: 38560434227

Env ✅​pass 🙈​skip Time
✅​ aws linux-2core-8gb 286 15 3:34
✅​ aws-windows-latest-4core-16gb 288 13 3:49
✅​ azure linux-2core-8gb 285 15 4:27
✅​ azure-windows-latest-4core-16gb 287 13 5:35
✅​ gcp linux-2core-8gb 286 15 4:01
✅​ gcp-windows-latest-4core-16gb 288 13 3:54
Top 4 slowest tests (at least 2 minutes):
duration env testname
4:51 azure-windows-latest-4core-16gb TestAccept
2:39 azure-windows-latest-4core-16gb TestSetupLocalServerlessProvision
2:32 aws-windows-latest-4core-16gb TestAccept
2:28 gcp-windows-latest-4core-16gb TestAccept

@github-actions github-actions Bot added the DABs DABs related issues label Oct 14, 2026
Comment thread libs/testserver/workspace_test.go Outdated
"github.com/stretchr/testify/require"
)

func TestWorkspaceIDsAreShortAndUnique(t *testing.T) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this test needed? we can see that ids are unique and start from 1000.

@shreyas-goenka
shreyas-goenka requested a review from denik October 14, 2026 12:57
@shreyas-goenka
shreyas-goenka marked this pull request as ready for review October 14, 2026 12:57
@shreyas-goenka
shreyas-goenka requested review from a team as code owners October 14, 2026 12:57
@shreyas-goenka
shreyas-goenka merged commit fb6e960 into main Oct 14, 2026
25 checks passed
@shreyas-goenka
shreyas-goenka deleted the shreyas-goenka_data/testserver-short-workspace-ids branch October 14, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DABs DABs related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants