Skip to content

Let deployment history config override the environment - #7045

Merged
shreyas-goenka merged 1 commit into
mainfrom
shreyas-goenka_data/shreyas-goenka/dms-config-env-stack
Oct 14, 2026
Merged

shreyas-goenka merged 1 commit into
mainfrom
shreyas-goenka_data/shreyas-goenka/dms-config-env-stack

Conversation

@shreyas-goenka

@shreyas-goenka shreyas-goenka commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Changes

Explicit experimental.deployment_history configuration now overrides DATABRICKS_BUNDLE_DEPLOYMENT_HISTORY, including an explicit false. An omitted field continues to use the environment setting.

Tests

New unit tests.

@github-actions github-actions Bot added the DABs DABs related issues label Oct 14, 2026
@shreyas-goenka
shreyas-goenka added this pull request to stack #7047 October 14, 2026 12:22
@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: 3a65fe4

Run: 38560602539

Env ✅​pass 🙈​skip Time
✅​ aws linux-2core-8gb 276 15 7:06
✅​ aws-windows-latest-4core-16gb 278 13 3:22
✅​ azure linux-2core-8gb 275 15 4:50
✅​ azure-windows-latest-4core-16gb 277 13 3:24
✅​ gcp linux-2core-8gb 276 15 4:37
✅​ gcp-windows-latest-4core-16gb 278 13 4:31
Top 4 slowest tests (at least 2 minutes):
duration env testname
4:19 gcp-windows-latest-4core-16gb TestAccept
3:19 aws-windows-latest-4core-16gb TestAccept
3:13 azure-windows-latest-4core-16gb TestAccept
2:44 aws linux-2core-8gb TestTelemetryEndpoint

@shreyas-goenka
shreyas-goenka requested a review from denik October 14, 2026 12:45
@shreyas-goenka
shreyas-goenka marked this pull request as ready for review October 14, 2026 12:45
@shreyas-goenka
shreyas-goenka requested review from a team as code owners October 14, 2026 12:45
Comment thread bundle/env/dms.go
return *configured
}
value, _ := get(ctx, []string{DeploymentHistoryVariable})
return value == "true"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: typically for env var any non-empty string is true. e.g. DATABRICKS_BUNDLE_DEPLOYMENT_HISTORY=1

@shreyas-goenka
shreyas-goenka added this pull request to the merge queue Oct 14, 2026
Merged via the queue into main with commit ba7e6e1 Oct 14, 2026
26 checks passed
@shreyas-goenka
shreyas-goenka deleted the shreyas-goenka_data/shreyas-goenka/dms-config-env-stack branch October 14, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DABs DABs related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants