Repository navigation
Skip redundant DMS resources.json uploads - #7056
Draft
shreyas-goenka wants to merge 2 commits into
Draft
shreyas-goenka wants to merge 2 commits into
shreyas-goenka wants to merge 2 commits into
Conversation
shreyas-goenka
added this pull request to stack #7047
October 14, 2026 14:54
Collaborator
Integration test reportCommit: 0d4f9e8
14 interesting tests: 7 FAIL, 7 flaky
Top 14 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Upload the DMS resources.json marker once on first deployment or migration, then skip routine uploads. Keep direct-state uploads and local state writes unchanged.
Stacked above #7055. Confirmed-DMS corruption recovery follows separately.
Why
DMS already records resource changes and versions. Re-uploading the marker on every deploy is redundant; its persisted serial is a checkpoint, while DMS remains authoritative.
Tests
Focused package tests and scoped Go lint pass. State/DMS acceptance passes: 42 directories, 58 variants, zero skips. Targeted assertions cover first/update/no-op writes of 1/0/0, one migration write, stable IDs, and advancing service versions.
Implementation and PR description written with Codex.