Skip to content

Skip redundant DMS resources.json uploads - #7056

Draft
shreyas-goenka wants to merge 2 commits into
shreyas-goenka_data/shreyas-goenka/dms-marker-selection-stackfrom
shreyas-goenka_data/shreyas-goenka/dms-marker-upload-stack
Draft

shreyas-goenka wants to merge 2 commits into
shreyas-goenka_data/shreyas-goenka/dms-marker-selection-stackfrom
shreyas-goenka_data/shreyas-goenka/dms-marker-upload-stack

Conversation

@shreyas-goenka

Copy link
Copy Markdown
Contributor

Changes

Upload the DMS resources.json marker once on first deployment or migration, then skip routine uploads. Keep direct-state uploads and local state writes unchanged.

Stacked above #7055. Confirmed-DMS corruption recovery follows separately.

Why

DMS already records resource changes and versions. Re-uploading the marker on every deploy is redundant; its persisted serial is a checkpoint, while DMS remains authoritative.

Tests

Focused package tests and scoped Go lint pass. State/DMS acceptance passes: 42 directories, 58 variants, zero skips. Targeted assertions cover first/update/no-op writes of 1/0/0, one migration write, stable IDs, and advancing service versions.

Implementation and PR description written with Codex.

@shreyas-goenka
shreyas-goenka added this pull request to stack #7047 October 14, 2026 14:54
@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: 0d4f9e8

Run: 38584727256

Env ❌​FAIL 🔄​flaky ✅​pass 🙈​skip Time
❌​ aws linux-2core-8gb 7 296 26 19:51
❌​ aws-windows-latest-4core-16gb 7 4 294 24 24:42
❌​ azure linux-2core-8gb 7 3 292 26 26:14
❌​ azure-windows-latest-4core-16gb 7 1 296 24 23:37
❌​ gcp linux-2core-8gb 7 296 26 24:15
❌​ gcp-windows-latest-4core-16gb 7 298 24 20:21
14 interesting tests: 7 FAIL, 7 flaky
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
❌​ TestAccept ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/dms/existing-state ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/dms/existing-state/DMS= ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
🔄​ TestAccept/bundle/dms/multiple-resources ✅​p 🔄​f ✅​p ✅​p ✅​p ✅​p
🔄​ TestAccept/bundle/dms/multiple-resources/DMS=true ✅​p 🔄​f ✅​p ✅​p ✅​p ✅​p
🔄​ TestAccept/bundle/dms/record-failure ✅​p ✅​p 🔄​f ✅​p ✅​p ✅​p
🔄​ TestAccept/bundle/dms/record-failure/DMS=true ✅​p ✅​p 🔄​f ✅​p ✅​p ✅​p
❌​ TestAccept/bundle/dms/repeated-migration ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/dms/repeated-migration/DMS=true ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/dms/stale-local-state ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/dms/stale-local-state/DMS= ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
🔄​ TestAccept/bundle/dms/stale-plan ✅​p 🔄​f ✅​p ✅​p ✅​p ✅​p
🔄​ TestAccept/bundle/dms/stale-plan/DMS=true/READPLAN=1 ✅​p 🔄​f ✅​p ✅​p ✅​p ✅​p
🔄​ TestSyncNestedFolderDoesntFailOnNonEmptyDirectory ✅​p ✅​p 🔄​f 🔄​f ✅​p ✅​p
Top 14 slowest tests (at least 2 minutes):
duration env testname
3:12 azure-windows-latest-4core-16gb TestAccept/bundle/dms/stale-plan/DMS=true/READPLAN=1
2:52 gcp-windows-latest-4core-16gb TestAccept/bundle/dms/no-drift/DMS=true
2:40 gcp linux-2core-8gb TestAccept/bundle/dms/declined-deploy/DMS=true
2:34 aws-windows-latest-4core-16gb TestAccept/bundle/dms/successful-recreate/DMS=true
2:30 gcp-windows-latest-4core-16gb TestAccept/bundle/dms/marker-writes/DMS=true
2:22 aws linux-2core-8gb TestAccept/bundle/dms/stale-plan/DMS=true/READPLAN=
2:16 azure linux-2core-8gb TestFilerRecursiveDelete/workspace_files_extensions
2:15 aws linux-2core-8gb TestAccept/bundle/dms/marker-writes/DMS=true
2:14 azure-windows-latest-4core-16gb TestImportDirDoesNotOverwrite
2:13 azure-windows-latest-4core-16gb TestAccept/bundle/dms/successful-recreate/DMS=true
2:13 gcp linux-2core-8gb TestAccept/bundle/dms/no-drift/DMS=true
2:10 aws-windows-latest-4core-16gb TestAccept/bundle/dms/multiple-resources/DMS=true
2:09 azure-windows-latest-4core-16gb TestAccept/bundle/dms/declined-deploy/DMS=true
2:06 gcp-windows-latest-4core-16gb TestAccept/bundle/dms/stale-plan/DMS=true/READPLAN=

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DABs DABs related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants