Skip to content

direct: add Bind and BindAndUpdate plan actions - #7059

Draft
shreyas-goenka wants to merge 1 commit into
isaac/dmsbind-1-confirmfrom
isaac/dmsbind-2-engine
Draft

shreyas-goenka wants to merge 1 commit into
isaac/dmsbind-1-confirmfrom
isaac/dmsbind-2-engine

Conversation

@shreyas-goenka

Copy link
Copy Markdown
Contributor

Adds Bind/BindAndUpdate plan actions to the direct engine: when DeploymentBundle.BindKey names a resource, CalculatePlan reads it by BindID and plans an unchanged adopt or an in-place update (recreate/resize is rejected), and apply takes the id from the plan entry. Nothing sets BindKey yet; the next PR wires it up for DMS.

This pull request and its description were written by Isaac.

CalculatePlan can now adopt an existing workspace resource: when
DeploymentBundle.BindKey names a resource, it is read by BindID instead of
its state entry, and planned as Bind (config matches) or BindAndUpdate (an
in-place update applies the config). Changes that need a recreate or resize
are rejected. Apply records a Bind without an API write and runs a normal
update for BindAndUpdate, taking the id from the plan entry because the
resource is not in state yet. Nothing sets BindKey yet; DMS bind uses it in
a follow-up.

Co-authored-by: Isaac <no-reply@databricks.com>
@shreyas-goenka
shreyas-goenka added this pull request to stack #7062 October 14, 2026 15:03
@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: d52fe57

Run: 38586064046

Env 🔄​flaky ✅​pass 🙈​skip Time
✅​ aws linux-2core-8gb 276 15 10:52
✅​ aws-windows-latest-4core-16gb 278 13 8:07
🔄​ azure linux-2core-8gb 1 274 15 10:34
✅​ azure-windows-latest-4core-16gb 277 13 7:57
✅​ gcp linux-2core-8gb 276 15 9:48
✅​ gcp-windows-latest-4core-16gb 278 13 8:42
Test Name azure linux-2core-8gb
🔄​ TestSyncNestedSpacePlusAndHashAreEscapedSync 🔄​f
Top 11 slowest tests (at least 2 minutes):
duration env testname
5:00 azure-windows-latest-4core-16gb TestAccept
3:20 gcp-windows-latest-4core-16gb TestAccept
3:11 aws-windows-latest-4core-16gb TestAccept
2:48 azure-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsRead
2:29 aws-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsRead
2:28 gcp linux-2core-8gb TestFilerRecursiveDelete/workspace_files
2:11 azure-windows-latest-4core-16gb TestFilerWorkspaceNotebook/sqlNb.sql
2:10 aws linux-2core-8gb TestFilerWorkspaceFilesExtensionsReadDir
2:02 aws linux-2core-8gb TestTelemetryEndpoint
2:01 azure-windows-latest-4core-16gb TestWorkspaceFilesExtensionsNotebooksAreNotDeletedAsFiles
2:01 aws linux-2core-8gb TestFilerWorkspaceFilesExtensionsRead

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants